arvindKandpal-ksolves opened a new pull request, #8855:
URL: https://github.com/apache/hbase/pull/8855
Backport of #8852 to branch-2.6.
### Problem
The hbtop usage showed -D options after the other options:
usage: hbase hbtop [opts] [-D<property=value>]*
But -D only works before the other options, so following the usage fails:
$ hbase hbtop -b -n 1 -Dhbase.client.retries.number=1
ERROR hbtop.HBTop: Unable to parse options
UnrecognizedOptionException: Unrecognized option:
-Dhbase.client.retries.number=1
### Changes
- `HBTop.java` (help text only): usage is now `hbase hbtop
[-D<property=value>]* [opts]`, with a note that -D must come first.
- The ZooKeeper example is kept as is, since ZKConnectionRegistry is the
default on branch-2.6. The bootstrap servers example from #8852 is not added
here.
### Testing
- hbase-hbtop unit tests pass on branch-2.6. No new test, since only help
text changed.
- Ran HBTop from the branch-2.6 build: the old order still fails with
UnrecognizedOptionException, and the new order passes option parsing and uses
the given -D settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
