kgeisz commented on PR #8845: URL: https://github.com/apache/hbase/pull/8845#issuecomment-6695939016
Hey @anmolnar and @VladRodionov, I have addressed some of the review suggestions you shared. Can I get another round of reviews. IMO, the biggest concern was an error occurring when creating `.backup.complete` and resulting in the backup failing. I chose the "best effort" approach that catches the exception in `HBackupFileSystem.writeBackupCompleteMarker()`. Some items are still unaddressed, and I will state my reasoning: 1. Marker creation is not atomic - `.backup.complete` is just an empty file, so it's creation is already atomic 2. Compatibility with existing backups is unresolved - Continuous Backup and PITR is a new feature. IMO we don't need to worry about existing backups not having the `.backup.complete` file since PITR does not apply to non-continuous backups that have been around already. 3. Write the backup ID and completion timestamp into `.backup.complete` file - IMO this is not necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
