[
https://issues.apache.org/jira/browse/HBASE-30504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139470#comment-18139470
]
Hudson commented on HBASE-30504:
--------------------------------
Results for branch branch-2
[build #1503 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1503/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1503/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1503/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1503/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1503/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk17 hadoop3 checks{color}
-- For more information [see jdk17
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1503/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk21 hadoop3 checks{color}
-- For more information [see jdk21
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1503/JDK21_20Nightly_20Build_20Report_20_28Hadoop3_29/]
> CacheConfig#onConfigurationChange ignores column family cache settings
> ----------------------------------------------------------------------
>
> Key: HBASE-30504
> URL: https://issues.apache.org/jira/browse/HBASE-30504
> Project: HBase
> Issue Type: Bug
> Components: BlockCache
> Reporter: Xiao Liu
> Assignee: Xiao Liu
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0-alpha-1, 2.7.0, 3.1.0, 3.0.1, 2.6.8, 2.5.17
>
>
> {\{CacheConfig}} combines the global configuration with the column family
> settings when it is created. A family with \{{BLOCKCACHE => false}} does not
> cache data blocks, and the family's \{{CACHE_DATA_ON_WRITE}} and
> \{{EVICT_BLOCKS_ON_CLOSE}} take effect even when the global settings are off.
> {\{CacheConfig#onConfigurationChange}}, added in HBASE-28517, only rereads
> the global settings and overwrites these values. \{{HStore}} registers its
> \{{CacheConfig}} with the \{{ConfigurationManager}}, so any
> \{{update_config}}, even one that changes no cache setting, has these effects
> on every open store:
> * \{{BLOCKCACHE => false}}: data blocks are cached on read again. If
> \{{hbase.rs.cacheblocksonwrite}} is true, they are also cached on write,
> which HBASE-29623 fixed.
> * \{{CACHE_DATA_ON_WRITE => true}}: cache on write is turned off unless
> enabled globally.
> * \{{EVICT_BLOCKS_ON_CLOSE => true}}: evict on close is turned off unless
> enabled globally.
> The wrong values remain until the region is reopened.
> The fix is to retain the family settings in \{{CacheConfig}} and use the same
> logic at construction and on reload.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
