[
https://issues.apache.org/jira/browse/HBASE-30521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18142002#comment-18142002
]
Hudson commented on HBASE-30521:
--------------------------------
Results for branch master
[build #219 on
builds.a.o|https://ci-hbase.apache.org/job/HBase-Integration-Test/job/master/219/]:
(/) *{color:green}+1 overall{color}*
----
details (if available):
(/) {color:green}+1 client integration test for 3.3.5 {color}
(/) {color:green}+1 client integration test for 3.3.5 with shaded hadoop
client{color}
(/) {color:green}+1 client integration test for 3.3.6 {color}
(/) {color:green}+1 client integration test for 3.3.6 with shaded hadoop
client{color}
(/) {color:green}+1 client integration test for 3.4.0 {color}
(/) {color:green}+1 client integration test for 3.4.0 with shaded hadoop
client{color}
(/) {color:green}+1 client integration test for 3.4.1 {color}
(/) {color:green}+1 client integration test for 3.4.1 with shaded hadoop
client{color}
(/) {color:green}+1 client integration test for 3.4.2 {color}
(/) {color:green}+1 client integration test for 3.4.2 with shaded hadoop
client{color}
(/) {color:green}+1 client integration test for 3.4.3 {color}
(/) {color:green}+1 client integration test for 3.4.3 with shaded hadoop
client{color}
> BlockCacheUtil JSON serializer includes transient BucketCache internals
> -----------------------------------------------------------------------
>
> Key: HBASE-30521
> URL: https://issues.apache.org/jira/browse/HBASE-30521
> Project: HBase
> Issue Type: Bug
> Components: BlockCache
> Reporter: Julian Chandra Sutadi
> Assignee: Julian Chandra Sutadi
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0-alpha-1, 2.7.0, 3.1.0, 3.0.1, 2.6.8
>
>
> HBASE-29215 fixed the block cache JSON view for {{BucketCache}} by marking
> the cache internals (e.g. {{backingMap}}, {{ioEngine}}) {{transient}}, which
> Gson excludes by default.
> HBASE-29325 later changed the serializer in {{BlockCacheUtil}} to
> {{excludeFieldsWithModifiers(Modifier.PRIVATE)}}. In [PR
> #6999|https://github.com/apache/hbase/pull/6999], excluding {{TRANSIENT}} and
> {{STATIC}} explicitly was dropped since they are Gson's default exclusions.
> However, {{excludeFieldsWithModifiers}} overrides those defaults rather than
> adding to them, so the non-private transient fields are serialized again. For
> example, {{BucketCache.backingMap}}, which holds an entry for every cached
> block, is included, so the size of the JSON view grows with the number of
> cached blocks. This is the concern about serializing the whole BucketCache
> raised in the same PR.
> The suggested fix is to pass the defaults along with {{PRIVATE}}, i.e.
> {{excludeFieldsWithModifiers(Modifier.PRIVATE, Modifier.TRANSIENT,
> Modifier.STATIC)}}. We will submit the fix proposal soon.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
