VladRodionov commented on PR #8844: URL: https://github.com/apache/hbase/pull/8844#issuecomment-6786817406
on Claude 2. comment. Confirmed. There are no remaining callers of `lruInstance(...).blockCache()` after the LRU tests were migrated to `LruCacheEngine`. `CacheAccessServiceTestInstance` is temporary test infrastructure used during the `BlockCache` -> `CacheEngine` migration. The remaining `BlockCache` support exists only for tests that have not yet been migrated and will be removed together with those tests/legacy APIs in the final migration. Because of that, I would prefer not to introduce separate permanent-looking factory abstractions for the two implementations. The relaxed generic is transitional and allows the same test fixture to be used while individual tests are migrated. I did change `blockCache()` to fail explicitly when the instance is backed by a native `CacheEngine`, rather than silently returning `null`, so accidental use from a migrated LRU test is detected immediately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
