kgeisz commented on PR #8809:
URL: https://github.com/apache/hbase/pull/8809#issuecomment-6836709514
Hey @anmolnar, I made some changes based on your review. I addressed the 3
major "Before merge" points, as well as the minor points in the "Smaller
robustness items" and "Nits" sections. Some notes on the changes:
- Cluster conf files are now moved to the data store root directory, where
they have their hostnames modified and are used by their respective Docker
container.
- Conf files are moved and set up by Python before starting the Docker
containers.
- Conf files are deleted along with the data store root directory after
the containers are stopped.
- Addresses 1 and 2 in "Before Merge" section of review.
- Added `ORIG_ACTIVE_CLUSTER_CONF_DIR` and `ORIG_REPLICA_CLUSTER_CONF_DIR`
config values to the `.env` file.
- The `ACTIVE_CLUSTER_CONF_DIR` and `REPLICA_CLUSTER_CONF_DIR` config
values still exist, but now point to the data store root directory.
- Updated test results Jira comment with "Read-Replica Jenkins Test Results
for branch..."
- Addresses 3 in "Before Merge" section of review.
- Removed `branch-2` from `getCronParams()` in the read-replica
`Jenkinsfile` since the feature will not be back-ported to this branch.
- Also, `branch-3` is now tested on a different day than `master`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
