Copilot commented on code in PR #8887:
URL: https://github.com/apache/hbase/pull/8887#discussion_r4572086274
##########
hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/hbase-incompatibilities.mdx:
##########
@@ -205,15 +205,15 @@ Following abstract method has been removed:
HBASE-18733: WALKey has been purged completely in HBase 2.0.
Following are the changes to the WALKey:
-#### classWALKey [!toc]
+#### class WALKey [!toc]
Review Comment:
This heading has no explicit `[#id]`, so changing `classWALKey` changes its
generated anchor (`[!toc]` is part of the heading ID in this documentation).
Existing links to the old `#classwalkey-toc` anchor will stop resolving,
contrary to the PR description. Preserve the old ID explicitly while correcting
the display text, or leave the heading text unchanged.
##########
hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/bulk-data-generator-tool.mdx:
##########
@@ -88,15 +88,15 @@ Number of rows generated is
rows-per-mapper * mapper-count
```
-Size of each rows is (approximately)
+Size of each row is (approximately)
```
850 B
```
### Experiments
-These results are from a 11 node cluster having HBase and Hadoop service
running within self-managed test environment
+These results are from an 11 node cluster having HBase and Hadoop service
running within self-managed test environment
Review Comment:
The revised sentence still lacks the articles and uses singular `service`
for two components (`HBase and Hadoop service ... environment`). Please make
the sentence grammatically complete.
##########
hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/mapreduce.mdx:
##########
@@ -208,7 +208,7 @@ Valid program names are:
rowcounter: Count rows in HBase table
```
-Each of the valid program names are bundled MapReduce jobs.
+Each of the valid program names is bundled MapReduce jobs.
Review Comment:
The subject-verb edit leaves the predicate grammatically invalid: each
program name is not “jobs.” Please make the predicate singular as well,
otherwise this documented sentence still contains the grammar error this PR is
intended to fix.
##########
hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/hbase-incompatibilities.mdx:
##########
@@ -553,7 +553,7 @@ org/apache/hadoop/hbase/ServerLoad.getWriteRequestsCount:()I
| ---------------------------- |
-----------------------------------------------------------------------------------------------------------------------------------------
|
| This class became interface. | A client program may be interrupted by
IncompatibleClassChangeError or InstantiationError exception dependent on the
usage of this class. |
-### Mapreduce changes:
+### MapReduce changes:
Review Comment:
This heading also lacks an explicit id, so changing `Mapreduce` to
`MapReduce` changes its generated fragment and can break existing links. Please
preserve the old heading text or add an explicit id matching the existing
anchor, consistent with the PR description.
##########
hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/amv2.mdx:
##########
@@ -86,7 +86,7 @@ In this section we note some idiosyncrasies of operation as
an attempt at saving
### Region Transition RPC and RS Heartbeat can arrive at ~same time on Master
-Reporting Region Transition on a RegionServer is now a RPC distinct from RS
heartbeating ('RegionServerServices' Service). An heartbeat and a status update
can arrive at the Master at about the same time. The Master will update its
internal state for a Region but this same state is checked when heartbeat
processing. We may find the unexpected; i.e. a Region just reported as CLOSED
so heartbeat is surprised to find region OPEN on the back of the RS report. In
the new system, all slaves must cow to the Masters' understanding of cluster
state; the Master will kill/close any misaligned entities.
+Reporting Region Transition on a RegionServer is now an RPC distinct from RS
heartbeating ('RegionServerServices' Service). A heartbeat and a status update
can arrive at the Master at about the same time. The Master will update its
internal state for a Region but this same state is checked when heartbeat
processing. We may find the unexpected; i.e. a Region just reported as CLOSED
so heartbeat is surprised to find region OPEN on the back of the RS report. In
the new system, all slaves must cow to the Master's understanding of cluster
state; the Master will kill/close any misaligned entities.
Review Comment:
`cow to` means intimidate or subdue, not comply with an authority, so this
correction leaves the sentence with the wrong word. The intended meaning
appears to be that all RegionServers must conform to the Master's view of
cluster state.
##########
hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/tracing.mdx:
##########
@@ -20,7 +20,7 @@ See this section in hbase-env.sh
# export HBASE_TRACE_OPTS="-Dotel.resource.attributes=service.name=HBase
-Dotel.traces.exporter=logging otel.metrics.exporter=none"
```
-Uncomment this line to enable tracing. The default config is to output the
tracing data to log. Please see the documentation for
[opentelemetry-java-instrumentation](https://github.com/open-telemetry/opentelemetry-java-instrumentation)
for more details on how to export tracing data to other tracing system such as
OTel collector, jaeger or zipkin, what does the _service.name_ mean, and how to
change the sampling rate, etc.
+Uncomment this line to enable tracing. The default config is to output the
tracing data to log. Please see the documentation for
[opentelemetry-java-instrumentation](https://github.com/open-telemetry/opentelemetry-java-instrumentation)
for more details on how to export tracing data to other tracing systems such
as OTel collector, jaeger or zipkin, what does the _service.name_ mean, and how
to change the sampling rate, etc.
Review Comment:
The revised sentence still uses an embedded direct-question form: “what does
the _service.name_ mean.” This should be “what the _service.name_ means” so the
grammar correction is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]