Apache9 commented on code in PR #8880:
URL: https://github.com/apache/hbase/pull/8880#discussion_r4586103049


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/SnapshotScannerHDFSAclController.java:
##########
@@ -493,24 +492,24 @@ private void removeUserTableHdfsAcl(Table aclTable, 
String userName, TableName t
     }
   }
 
-  private UserPermission getUserGlobalPermission(Configuration conf, String 
userName)
+  private UserPermission getUserGlobalPermission(Connection conn, String 
userName)
     throws IOException {
-    List<UserPermission> permissions = 
PermissionStorage.getUserPermissions(conf,
-      PermissionStorage.ACL_GLOBAL_NAME, null, null, userName, true);
+    List<UserPermission> permissions =
+      PermissionUtils.filter(PermissionStorage.getGlobalPermissions(conn), 
userName);
     return permissions.size() > 0 ? permissions.get(0) : null;

Review Comment:
   What is the new order mean? I haven't changed any order here, and this is 
for checking global permission?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to