[ 
https://issues.apache.org/jira/browse/HBASE-30534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18146230#comment-18146230
 ] 

Hudson commented on HBASE-30534:
--------------------------------

Results for branch master
        [build #225 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase-Integration-Test/job/master/225/]:
 (/) *{color:green}+1 overall{color}*
----
details (if available):



(/) {color:green}+1 client integration test for 3.3.5 {color}
(/) {color:green}+1 client integration test for 3.3.5 with shaded hadoop 
client{color}


(/) {color:green}+1 client integration test for 3.3.6 {color}
(/) {color:green}+1 client integration test for 3.3.6 with shaded hadoop 
client{color}


(/) {color:green}+1 client integration test for 3.4.0 {color}
(/) {color:green}+1 client integration test for 3.4.0 with shaded hadoop 
client{color}


(/) {color:green}+1 client integration test for 3.4.1 {color}
(/) {color:green}+1 client integration test for 3.4.1 with shaded hadoop 
client{color}


(/) {color:green}+1 client integration test for 3.4.2 {color}
(/) {color:green}+1 client integration test for 3.4.2 with shaded hadoop 
client{color}


(/) {color:green}+1 client integration test for 3.4.3 {color}
(/) {color:green}+1 client integration test for 3.4.3 with shaded hadoop 
client{color}


> The filterUser logic should not be placed in PermissionStorage
> --------------------------------------------------------------
>
>                 Key: HBASE-30534
>                 URL: https://issues.apache.org/jira/browse/HBASE-30534
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>              Labels: pull-request-available
>
> HBase's ACL model supports group, which is stored as
> {noformat}
> @GROUP_NAME
> {noformat}
> in acl table.
> And when checking whether a user has proper permissions or getting the 
> permissions for a user, we need to expand the group to a list of users. The 
> filterUser parameter is used in this case.
> But PermissionStorage is designed as class to communicate with the acl table, 
> so putting the filterUser logic in it, will mess up the logic for 
> implementation grant/revoke.
> So I prefer we do a refactoring, to leave PermissionStorage as simple as 
> possible, and move the filterUser logic to upper layer, which could make the 
> code easier to understand.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to