arvindKandpal-ksolves opened a new pull request, #8905:
URL: https://github.com/apache/hbase/pull/8905
The usage text of WALPerformanceEvaluation does not match how the tool
parses its arguments.
Changes:
- -traceFreq: also skip its value, so commands that still pass "-traceFreq
<N>" work again (broken since HBASE-25373). Usage now says it is not supported
any more.
- Usage: "-h|-help" changed to "-h|--help", which is what the parser accepts.
- Usage: add the missing "-compress" option.
- An option given without its value now prints the usage instead of throwing
ArrayIndexOutOfBoundsException.
- TestFSHLogProviderWithConcurrentWrites: add a test that runs the tool with
"-traceFreq 0.5".
Testing:
- New test fails without the fix and passes with it.
- TestFSHLogProviderWithConcurrentWrites and
TestBoundedRegionGroupingStrategyUsingWPETool pass; spotless passes.
- Manual runs on the local filesystem: "-traceFreq 0.5", "--help",
"-threads" with no value and "-compress" all behave as described above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]