[
https://issues.apache.org/jira/browse/HBASE-30534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18148559#comment-18148559
]
Hudson commented on HBASE-30534:
--------------------------------
Results for branch branch-2
[build #1509 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1509/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1509/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1509/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1509/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1509/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk17 hadoop3 checks{color}
-- For more information [see jdk17
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1509/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk21 hadoop3 checks{color}
-- For more information [see jdk21
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1509/JDK21_20Nightly_20Build_20Report_20_28Hadoop3_29/]
> The filterUser logic should not be placed in PermissionStorage
> --------------------------------------------------------------
>
> Key: HBASE-30534
> URL: https://issues.apache.org/jira/browse/HBASE-30534
> Project: HBase
> Issue Type: Improvement
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0-alpha-1, 2.7.0, 3.1.0, 3.0.1, 2.6.8, 2.5.17
>
>
> HBase's ACL model supports group, which is stored as
> {noformat}
> @GROUP_NAME
> {noformat}
> in acl table.
> And when checking whether a user has proper permissions or getting the
> permissions for a user, we need to expand the group to a list of users. The
> filterUser parameter is used in this case.
> But PermissionStorage is designed as class to communicate with the acl table,
> so putting the filterUser logic in it, will mess up the logic for
> implementation grant/revoke.
> So I prefer we do a refactoring, to leave PermissionStorage as simple as
> possible, and move the filterUser logic to upper layer, which could make the
> code easier to understand.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)