Sigma-Ma commented on code in PR #174:
URL: https://github.com/apache/hbase-connectors/pull/174#discussion_r4657438703


##########
spark4/hbase-spark4/src/main/scala/org/apache/hadoop/hbase/spark/datasources/HBasePartitionReader.scala:
##########
@@ -86,6 +86,20 @@ class HBasePartitionReader(
     .map(_.toBoolean)
     .getOrElse(HBaseSparkConf.DEFAULT_QUERY_CACHEBLOCKS)
 
+  // Resolve only for Scan, and warn at most once per reader.
+  private lazy val scanBatchSize: Option[Int] = {
+    val batch = 
properties.get(HBaseSparkConf.QUERY_BATCHSIZE).map(_.toInt).filter(_ > 0)
+    if (hasNullCheck || pushDownFilter.nonEmpty) {
+      batch.foreach {
+        size =>
+          logWarning(

Review Comment:
   Yeah, INFO makes sense here. I’ll use it in both connectors.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to