[
https://issues.apache.org/jira/browse/HBASE-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456008#comment-13456008
]
Todd Lipcon commented on HBASE-6783:
------------------------------------
+ String readOnConf = conf.get("dfs.client.read.shortcircuit");
+ return (readOnConf == null ? true : Boolean.parseBoolean(readOnConf));
can use conf.getBoolean()
The config/property name should also be clear that it's a setting for tests -
eg hbase.tests.use.shortcircuit.reads
----
+ private void readShortCircuit(){
+ if (isReadShortCircuitOn()){
+ String curUser = System.getProperty("user.name");
+ LOG.info("read short circuit is ON for user "+curUser);
style: space before {s, space after '+'
rename to enableReadShortCircuit()
----
+ if (util.isReadShortCircuitOn()){
+ LOG.info("dfs.client.read.shortcircuit is on, " +
+ "testFullSystemBubblesFSErrors is not executed");
+ return;
+ }
Can use junit Assume here
----
- there's a spurious whitespace change
> Make read short circuit the default
> -----------------------------------
>
> Key: HBASE-6783
> URL: https://issues.apache.org/jira/browse/HBASE-6783
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Fix For: 0.96.0
>
> Attachments: HBASE-6783.v1.patch
>
>
> Per mailing discussion, read short circuit has little or no drawback, hence
> should used by default. As a consequence, we activate it on the default tests.
> It's possible to launch the test with -Ddfs.client.read.shortcircuit=false to
> execute the tests without the shortcircuit, it will be used for some builds
> on trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
