[ 
https://issues.apache.org/jira/browse/HBASE-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456295#comment-13456295
 ] 

Hadoop QA commented on HBASE-6794:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12545260/HBASE-6794.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The patch appears to cause mvn compile goal to fail.

    -1 findbugs.  The patch appears to cause Findbugs (version 1.3.9) to fail.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.replication.TestReplication
                  org.apache.hadoop.hbase.master.TestSplitLogManager

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2877//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2877//console

This message is automatically generated.
                
> FilterBase should provide a default implementation of toByteArray
> -----------------------------------------------------------------
>
>                 Key: HBASE-6794
>                 URL: https://issues.apache.org/jira/browse/HBASE-6794
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6794.patch
>
>
> See HBASE-6657, FilterBase provides stub implementations for other Filter 
> methods, it seems reasonable for it to provide a default implementation for 
> toByteArray, for Filters that don't need special serialization (e.g. ones 
> with no state).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to