[
https://issues.apache.org/jira/browse/HBASE-6317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457143#comment-13457143
]
Jimmy Xiang commented on HBASE-6317:
------------------------------------
I think the idea of the patch is great. However, I prefer to isolate the change
in EnableTableHandler and don't touch AssignmentManager.
Even roundrobinassignment is set, if there is a server entry in meta for a
region of an enabling table, I think we can just ignore it and assign to the
server if the server is online. So we don't need to pass masterrestart around.
We can update the region plan only in EnableTableHandler. The assumption is
that if the server entry is already in meta, we should obey it and it is there
because of a previous roundrobinassignment. What do you think?
> Master clean start up and Partially enabled tables make region assignment
> inconsistent.
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-6317
> URL: https://issues.apache.org/jira/browse/HBASE-6317
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.92.3, 0.94.3
>
> Attachments: HBASE-6317_94_3.patch, HBASE-6317_94.patch,
> HBASE-6317_trunk_2.patch
>
>
> If we have a table in partially enabled state (ENABLING) then on HMaster
> restart we treat it as a clean cluster start up and do a bulk assign.
> Currently in 0.94 bulk assign will not handle ALREADY_OPENED scenarios and it
> leads to region assignment problems. Analysing more on this we found that we
> have better way to handle these scenarios.
> {code}
> if (false == checkIfRegionBelongsToDisabled(regionInfo)
> && false == checkIfRegionsBelongsToEnabling(regionInfo)) {
> synchronized (this.regions) {
> regions.put(regionInfo, regionLocation);
> addToServers(regionLocation, regionInfo);
> }
> {code}
> We dont add to regions map so that enable table handler can handle it. But
> as nothing is added to regions map we think it as a clean cluster start up.
> Will come up with a patch tomorrow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
