[ 
https://issues.apache.org/jira/browse/HBASE-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459052#comment-13459052
 ] 

stack commented on HBASE-6804:
------------------------------

Thats a lot of removed DEBUG logging.

A pool of one thread only seems odd... is it just because you want to do this 
scheduleAtFixedRate?

+  private final ScheduledExecutorService scheduleThreadPool =
+    Executors.newScheduledThreadPool(1,
+      new ThreadFactoryBuilder()
+        .setNameFormat("Replication Statistics #%d")
+        .setDaemon(true)
+        .build());

Threads usually have their host as prefix; check out other places in server 
where we name threads.

Patch seems good.  +1 on commit.

                
> [replication] lower the amount of logging to a more human-readable level
> ------------------------------------------------------------------------
>
>                 Key: HBASE-6804
>                 URL: https://issues.apache.org/jira/browse/HBASE-6804
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6804-0.94.patch
>
>
> We need stop logging every time replication decides to do something. It used 
> to be extremely useful when the code base was younger but now it should be 
> possible to bring it down while keeping it relevant.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to