[ 
https://issues.apache.org/jira/browse/HBASE-6501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459202#comment-13459202
 ] 

Hadoop QA commented on HBASE-6501:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12545816/HBASE-6501-0.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 11 new or modified tests.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    -1 javadoc.  The javadoc tool appears to have generated 139 warning 
messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to introduce 14 new Findbugs (version 
1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2902//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2902//console

This message is automatically generated.
                
> Integrate with unit-testing tools of hadoop's metrics2 framework
> ----------------------------------------------------------------
>
>                 Key: HBASE-6501
>                 URL: https://issues.apache.org/jira/browse/HBASE-6501
>             Project: HBase
>          Issue Type: Sub-task
>          Components: metrics
>            Reporter: Alex Baranau
>            Assignee: Elliott Clark
>            Priority: Blocker
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6501-0.patch, HBASE-6501_2.patch, 
> HBASE-6501_3.patch, HBASE-6501.patch
>
>
> Hadoop's metrics2 framework provides handy tools to write unit-tests for 
> metrics sources. E.g. MetricsAsserts class. We want to use that too in HBase 
> unit-tests.
> Integration seems straightforward, wowever when integrating this piece we 
> faced maven bug: http://jira.codehaus.org/browse/MRRESOURCES-53. Hence we 
> decided to extract this into separate issue (originally was done in one of 
> the patches of HBASE-6411).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to