[
https://issues.apache.org/jira/browse/HBASE-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459563#comment-13459563
]
Hadoop QA commented on HBASE-6677:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545886/HBASE-6677.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
-1 javadoc. The javadoc tool appears to have generated 139 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 14 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2905//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2905//console
This message is automatically generated.
> Random ZooKeeper port in test can overrun max port
> --------------------------------------------------
>
> Key: HBASE-6677
> URL: https://issues.apache.org/jira/browse/HBASE-6677
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.96.0
> Reporter: Gregory Chanan
> Priority: Trivial
> Labels: noob
> Attachments: HBASE-6677.patch
>
>
> {code}
> while (true) {
> try {
> standaloneServerFactory = new NIOServerCnxnFactory();
> standaloneServerFactory.configure(
> new InetSocketAddress(tentativePort),
> configuration.getInt(HConstants.ZOOKEEPER_MAX_CLIENT_CNXNS,
> 1000));
> } catch (BindException e) {
> LOG.debug("Failed binding ZK Server to client port: " +
> tentativePort);
> // This port is already in use, try to use another.
> tentativePort++;
> continue;
> }
> break;
> }
> {code}
> In the case of failure and all the above ports have already been binded, you
> can extend past the max port. Need to check against a max value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
