[
https://issues.apache.org/jira/browse/HBASE-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460434#comment-13460434
]
Alex Baranau commented on HBASE-6410:
-------------------------------------
Oh, sorry, forgot to share some minor notes I took when looking at changes in
common classes:
1) TestMasterMetricsSourceFactory:
{noformat}
//This should throw an exception because there is no compat lib on the
class path.
CompatibilitySingletonFactory.getInstance(MasterMetricsSource.class);
{noformat}
This will throw an exception anyways, because now MasterMetricsSource*Factory*
is used.
2) MasterMetricsSourceImpl:
{noformat}
public void getMetrics(MetricsBuilder metricsBuilder, boolean all) {
[...]
metricsRegistry.snapshot(metricsRecordBuilder, true);
}
{noformat}
Should be metricsRegistry.snapshot(metricsRecordBuilder, *all*) ?
Same in hadoop-compat2
> Move RegionServer Metrics to metrics2
> -------------------------------------
>
> Key: HBASE-6410
> URL: https://issues.apache.org/jira/browse/HBASE-6410
> Project: HBase
> Issue Type: Sub-task
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Blocker
> Attachments: HBASE-6410-1.patch, HBASE-6410.patch
>
>
> Move RegionServer Metrics to metrics2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
