[ https://issues.apache.org/jira/browse/HBASE-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464465#comment-13464465 ]
stack commented on HBASE-6854: ------------------------------ Looking at the patch, why we do this: {code} - LOG.debug("Ephemeral node deleted, regionserver crashed?, " + - "clearing from RIT; rs=" + rs); + LOG.debug("Ephemeral node deleted, regionserver crashed?, offlining the region" + + rs.getRegion() + "clearing from RIT; rs=" + rs); {code} The lone 'rs' will become rs.toString. rs is a RegionState. When I look at RegionState.toString, it includes region name so why add the rs.getRegion? The above can be fixed on commit because otherwise, this looks like a good bug fix. > Deletion of SPLITTING node on split rollback should clear the region from RIT > ----------------------------------------------------------------------------- > > Key: HBASE-6854 > URL: https://issues.apache.org/jira/browse/HBASE-6854 > Project: HBase > Issue Type: Bug > Reporter: ramkrishna.s.vasudevan > Fix For: 0.94.3 > > Attachments: HBASE-6854.patch > > > If a failure happens in split before OFFLINING_PARENT, we tend to rollback > the split including deleting the znodes created. > On deletion of the RS_ZK_SPLITTING node we are getting a callback but not > remvoving from RIT. We need to remove it from RIT, anyway SSH logic is well > guarded in case the delete event comes due to RS down scenario. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira