[ 
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465308#comment-13465308
 ] 

stack commented on HBASE-6707:
------------------------------

Pull MockRegionServer up to top level in test now its used by master package 
and top-level package.  It was in master package because that was only place it 
was needed until now.

I will hold my nose when I commit stuff like this:

{code}
+  /**
+   * Exposed for testing!
+   */
+  public CompactSplitThread getCompactSplitThread() {
+    return this.compactSplitThread;
+  }
{code}

Rather than comment out, remove:

{code}
-    UTIL.createTable(TABLE_NAME, TEST_FAM);
+    // UTIL.createTable(TABLE_NAME, TEST_FAM);
{code}

That mocked hregion looks like it could be generally useful.  Nice.

Good on you Jesse.


                
> TEST 
> org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables
>  flaps
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-6707
>                 URL: https://issues.apache.org/jira/browse/HBASE-6707
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: Sameer Vaishampayan
>            Assignee: Jesse Yates
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: hbase-6707-v0.patch, hbase-6707-v1.patch, 
> hbase-6707-v2.patch
>
>
> https://builds.apache.org/job/HBase-TRUNK/3293/
> Error Message
> Archived HFiles 
> (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
>  should have gotten deleted, but didn't, remaining 
> files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
> Stacktrace
> java.lang.AssertionError: Archived HFiles 
> (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
>  should have gotten deleted, but didn't, remaining 
> files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
>       at org.junit.Assert.fail(Assert.java:93)
>       at org.junit.Assert.assertTrue(Assert.java:43)
>       at org.junit.Assert.assertNull(Assert.java:551)
>       at 
> org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:291)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to