[
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jesse Yates updated HBASE-6707:
-------------------------------
Attachment: hbase-6707-v3.patch
A far more conservative patch than the last one.
Thanks Ted for calling me out on mocking out ALL THE THINGS. Definitely a more
brittle approach (the logic was that the core compaction/split stuff doesn't
change all that often :) to just get a couple region to pump out a few hfiles
and compactions.
This new version just creates a simple HRegion, 2x writes a single key to
create an hfile via flushing and does a compaction to force hfile archiving.
Then it does the real checking with the LongTermHFileArchiver.
This is technically a smaller scope than the original test, but its ok because
(1) it tests real hfiles that follow the standard archival path, (2) uses a
real HFileCleaner to run the cleaner.
As long as the HFileCleaner and the rest of the system works correctly (which
is why we have other tests), then this test is sufficient to cover the validity
of the example classes.
Seem reasonable?
> TEST
> org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables
> flaps
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-6707
> URL: https://issues.apache.org/jira/browse/HBASE-6707
> Project: HBase
> Issue Type: Bug
> Components: test
> Reporter: Sameer Vaishampayan
> Assignee: Jesse Yates
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: hbase-6707-v0.patch, hbase-6707-v1.patch,
> hbase-6707-v2.patch, hbase-6707-v3.patch
>
>
> https://builds.apache.org/job/HBase-TRUNK/3293/
> Error Message
> Archived HFiles
> (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
> should have gotten deleted, but didn't, remaining
> files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
> Stacktrace
> java.lang.AssertionError: Archived HFiles
> (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
> should have gotten deleted, but didn't, remaining
> files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.assertTrue(Assert.java:43)
> at org.junit.Assert.assertNull(Assert.java:551)
> at
> org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:291)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
