[ 
https://issues.apache.org/jira/browse/HBASE-6735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466107#comment-13466107
 ] 

Hadoop QA commented on HBASE-6735:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12547072/0002-jira-HBASE-6735-89-fb-Remove-reflection-from-HBaseCl.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2966//console

This message is automatically generated.
                
> [89-fb] Remove reflection from HBaseClient
> ------------------------------------------
>
>                 Key: HBASE-6735
>                 URL: https://issues.apache.org/jira/browse/HBASE-6735
>             Project: HBase
>          Issue Type: Test
>            Reporter: Michal Gregorczyk
>            Assignee: Michal Gregorczyk
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 
> 0002-jira-HBASE-6735-89-fb-Remove-reflection-from-HBaseCl.patch
>
>
> Every time we read response in HBaseClient we create instance of valueClass 
> using reflection and Hadoop APIs. valueClass is set in a constructor of 
> HBaseClient to one of parameters. The parameter is always HbaseObjectWritable.
> We can remove reflection by hardcoding HbaseObjectWritable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to