[ 
https://issues.apache.org/jira/browse/HBASE-6797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesse Yates updated HBASE-6797:
-------------------------------

    Attachment: hbase-6797-v0.patch

Attaching patch to fix the test by removing the sleeps in favor of setting the 
modification time of the files. The test had to be upgraded to a MediumTest 
because the localFS impl doesn't correctly update the file stats (does an odd 
round down, but not really thing, at least in Hadoop-1.0), so switched to using 
a miniDFS cluster to back the fs.

Also
* added a test for removing directory entries (a case we thought was broken at 
Salesforce, but looks fine in test).
* slight commenting cleanup in TimeToLiveCleaner.

Yeah, the latter two could go into another patch, but they are pretty simple 
and go nicely with fix for this test.
                
> TestHFileCleaner#testHFileCleaning sometimes fails in trunk
> -----------------------------------------------------------
>
>                 Key: HBASE-6797
>                 URL: https://issues.apache.org/jira/browse/HBASE-6797
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>         Attachments: hbase-6797-v0.patch
>
>
> In build #3334, I saw:
> {code}
> java.lang.AssertionError: expected:<1> but was:<0>
>       at org.junit.Assert.fail(Assert.java:93)
>       at org.junit.Assert.failNotEquals(Assert.java:647)
>       at org.junit.Assert.assertEquals(Assert.java:128)
>       at org.junit.Assert.assertEquals(Assert.java:472)
>       at org.junit.Assert.assertEquals(Assert.java:456)
>       at 
> org.apache.hadoop.hbase.master.cleaner.TestHFileCleaner.testHFileCleaning(TestHFileCleaner.java:88)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to