[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467232#comment-13467232
]
Flavio Junqueira commented on HBASE-5937:
-----------------------------------------
bq. Its fine it doesn't need to split but Master needs some way of figuring
that w/ a particular implemenation, there is no need to split. How will you do
this?
I was wondering if the master really needs to be aware of splitting. To me it
sounds like a feature that is implementation-specific. The master should be
able to request the log stream for a region independent of how it gets it, no?
Am I missing anything?
bq. If only for that test, I'd say we file an issue to fix this ugly addition
to HLog only used in a single test....
Agreed, it is not pretty. I can create a jira to get rid of it.
bq. To my mind, class named HLogUtil is utility that could be used by any HLog
implementation. If that is not the case, call it FSHLogUtil?
Right now it makes no difference calling it HLogUtil or FSHLogUtil because even
the interface HLog is heavily file-oriented. I wouldn't discard calling it
FSHLogUtil and creating an HLogUtil in the case there are methods that are
implementation-independent. Right now they all seem to be tied to FSHLog
somehow.
I also see no issue currently with moving those methods to FSHLog directly.
Originally, having HLog, HLogUtil, FSHLog was just to have an interface, an
implementation of the interface, and the static methods related for
implementations of the interface. Separating them seems to make clear that the
static methods are FSHLog specific. I'd like to have another careful look just
to make sure I'm not missing anything.
It could be another jira too to decide if we call it FSHLogUtil or merge those
methods with FSHLog.
bq. You want to do your list in other JIRAs and get this patch committed now
(do you want to do one last update)?
Sounds like a good idea because we can then focus on more concrete issue to
refine it. It will make it more manageable. I'll do one more update shortly.
> Refactor HLog into an interface.
> --------------------------------
>
> Key: HBASE-5937
> URL: https://issues.apache.org/jira/browse/HBASE-5937
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Flavio Junqueira
> Priority: Minor
> Attachments: 5937-hlog-with-javadoc.txt, HBASE-5937.patch,
> HBASE-5937.patch, HBASE-5937.patch, HBASE-5937.patch, HBASE-5937.patch,
> org.apache.hadoop.hbase.client.TestMultiParallel-output.txt
>
>
> What the summary says. Create HLog interface. Make current implementation use
> it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
