[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flavio Junqueira updated HBASE-5937:
------------------------------------
Status: Patch Available (was: Open)
I have checked the new findbugs warning and they haven't been introduced by any
of the changes I made. They appear as new because I moved code around.
I have looked into finxing them, though. I fixed one about a volatile variable
by making it an AtomicInteger. The warning was about incrementing a volatile
variable.
There are two warnings about static variables being set to a mutable array in
HLog. This is due to the use of Bytes.toBytes(). I didn't want to change that,
so I left as is.
There two other warnings related to this code excerpt:
{noformat}
synchronized (closeLogSyncer) {
closeLogSyncer.set(true);
closeLogSyncer.notifyAll();
}
{noformat}
where closeLogSyncer is an AtomicBoolean, so the warning is saying that we
shouldn't synchronize. It sounds right to me, but I wanted to make sure that it
is correct. I can create a jira to fix it if I get a confirmation. It is a
pretty simple fix.
> Refactor HLog into an interface.
> --------------------------------
>
> Key: HBASE-5937
> URL: https://issues.apache.org/jira/browse/HBASE-5937
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Flavio Junqueira
> Priority: Minor
> Attachments: 5937-hlog-with-javadoc.txt, HBASE-5937.patch,
> HBASE-5937.patch, HBASE-5937.patch, HBASE-5937.patch, HBASE-5937.patch,
> HBASE-5937.v2.patch, HBASE-5937.v3.patch,
> org.apache.hadoop.hbase.client.TestMultiParallel-output.txt
>
>
> What the summary says. Create HLog interface. Make current implementation use
> it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
