[ 
https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468969#comment-13468969
 ] 

Hadoop QA commented on HBASE-6439:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12547613/hbase-6439-r0.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 12 new 
or modified tests.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
81 warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 5 new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2995//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2995//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2995//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2995//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2995//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2995//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2995//console

This message is automatically generated.
                
> Ignore .archive directory as a table
> ------------------------------------
>
>                 Key: HBASE-6439
>                 URL: https://issues.apache.org/jira/browse/HBASE-6439
>             Project: HBase
>          Issue Type: Bug
>          Components: io, regionserver
>    Affects Versions: 0.96.0
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>              Labels: newbie
>         Attachments: hbase-6439-r0.patch
>
>
> From a recent test run:
> {quote}
> 2012-07-22 02:27:30,699 WARN  [IPC Server handler 0 on 47087] 
> util.FSTableDescriptors(168): The following folder is in HBase's root 
> directory and doesn't contain a table descriptor, do consider deleting it: 
> .archive
> {quote}
> With the addition of HBASE-5547, table-level folders are no-longer all table 
> folders. FSTableDescriptors needs to then have a 'gold-list' that we can 
> update with directories that aren't tables so we don't have this kind of 
> thing showing up in the logs.
> Currently, we have the following block:
> {quote}
>     invocations++;
>     if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) {
>       cachehits++;
>       return HTableDescriptor.ROOT_TABLEDESC;
>     }
>     if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) {
>       cachehits++;
>       return HTableDescriptor.META_TABLEDESC;
>     }
> {quote}
> to handle special cases, but that's a bit clunky and not clean in terms of 
> table-level directories that need to be ignored.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to