[ 
https://issues.apache.org/jira/browse/HBASE-6916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469027#comment-13469027
 ] 

Hadoop QA commented on HBASE-6916:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12547626/HBASE-6916.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
83 warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 5 new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
                  org.apache.hadoop.hbase.client.TestShell
                  org.apache.hadoop.hbase.regionserver.wal.TestHLog

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2998//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2998//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2998//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2998//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2998//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2998//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2998//console

This message is automatically generated.
                
> HBA logs at info level errors that won't show in the shell
> ----------------------------------------------------------
>
>                 Key: HBASE-6916
>                 URL: https://issues.apache.org/jira/browse/HBASE-6916
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.90.6, 0.92.1, 0.94.1, 0.96.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 0.92.2, 0.94.3, 0.96.0
>
>         Attachments: HBASE-6916-0.94.patch, HBASE-6916.patch
>
>
> There is a weird interaction between the shell and HBA. When you try to close 
> a region that doesn't exist, it doesn't throw any error:
> {noformat}
> hbase(main):029:0> close_region 'thisisaninvalidregion'
> 0 row(s) in 0.0580 seconds
> {noformat}
> Normally one should get UnknownRegionException. Starting the shell with "-d" 
> I see what a non-shell user would see along with a ton of logging from ZK 
> (skipped here):
> {noformat}
> INFO client.HBaseAdmin: No server in .META. for thisisaninvalidregion; 
> pair=null
> {noformat}
> But again this is not the right message, it should have shown
> {noformat}
> INFO client.HBaseAdmin: No server in .META. for thisisaninvalidregion; 
> pair=null
> {noformat}
> And this is because that part of the code treats both UnknownRegionException 
> and NoServerForRegionException like if it was the same thing.
> There is also some ugliness in flush, compact, and split but it normally 
> doesn't show since the code treats everything like it's a table and sends a 
> TableNotFoundException.
> This jira is about making sure that the exceptions are correctly coming out.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to