[
https://issues.apache.org/jira/browse/HBASE-6758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469841#comment-13469841
]
Ted Yu commented on HBASE-6758:
-------------------------------
Thanks for your continued effort, Devaraj.
{code}
+ void prelogRoll(Path newLog) throws IOException {
{code}
I think the 'l' of 'log' should be capitalized.
Same here:
{code}
+ void postlogRoll(Path newLog) throws IOException {
{code}
nit: since the following line is modified, please add space after if:
{code}
- if(readAllEntriesToReplicateOrNextFile()) {
+ if(readAllEntriesToReplicateOrNextFile(fileInUse)) {
{code}
Please add javadoc for the new parameter:
{code}
/**
* Do the shipping logic
*/
- protected void shipEdits() {
+ protected void shipEdits(boolean fileInUse) {
{code}
> [replication] The replication-executor should make sure the file that it is
> replicating is closed before declaring success on that file
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-6758
> URL: https://issues.apache.org/jira/browse/HBASE-6758
> Project: HBase
> Issue Type: Bug
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6758-1-0.92.patch, 6758-2-0.92.patch,
> 6758-trunk-1.patch, 6758-trunk-2.patch, 6758-trunk-3.patch,
> TEST-org.apache.hadoop.hbase.replication.TestReplication.xml
>
>
> I have seen cases where the replication-executor would lose data to replicate
> since the file hasn't been closed yet. Upon closing, the new data becomes
> visible. Before that happens the ZK node shouldn't be deleted in
> ReplicationSourceManager.logPositionAndCleanOldLogs. Changes need to be made
> in ReplicationSource.processEndOfFile as well (currentPath related).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
