[
https://issues.apache.org/jira/browse/HBASE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474319#comment-13474319
]
Ted Yu commented on HBASE-6651:
-------------------------------
I got two test failures from TestHTablePool:
{code}
testCloseTablePool(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableReusablePool)
Time elapsed: 3.189 sec <<< FAILURE!
junit.framework.AssertionFailedError: expected:<4> but was:<0>
at junit.framework.Assert.fail(Assert.java:50)
at junit.framework.Assert.failNotEquals(Assert.java:287)
at junit.framework.Assert.assertEquals(Assert.java:67)
at junit.framework.Assert.assertEquals(Assert.java:199)
at junit.framework.Assert.assertEquals(Assert.java:205)
at
org.apache.hadoop.hbase.client.TestHTablePool$TestHTableReusablePool.testCloseTablePool(TestHTablePool.java:252)
...
testCloseTablePool(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableThreadLocalPool)
Time elapsed: 3.095 sec <<< FAILURE!
junit.framework.AssertionFailedError: expected:<1> but was:<0>
at junit.framework.Assert.fail(Assert.java:50)
at junit.framework.Assert.failNotEquals(Assert.java:287)
at junit.framework.Assert.assertEquals(Assert.java:67)
at junit.framework.Assert.assertEquals(Assert.java:199)
at junit.framework.Assert.assertEquals(Assert.java:205)
at
org.apache.hadoop.hbase.client.TestHTablePool$TestHTableThreadLocalPool.testCloseTablePool(TestHTablePool.java:328)
{code}
BTW, the following hunk for HBaseClient.java should be rebased:
{code}
***************
*** 402,412 ****
}
this.header = builder.build();
- this.setName("IPC Client (" + socketFactory.hashCode() +") connection
to " +
remoteId.getAddress().toString() +
((ticket==null)?" from an unknown user": (" from "
- + ticket.getUserName())));
- this.setDaemon(true);
}
private UserInformation getUserInfoPB(UserGroupInformation ugi) {
--- 482,491 ----
}
this.header = builder.build();
+ this.name = "IPC Client (" + socketFactory.hashCode() +") connection to
" +
remoteId.getAddress().toString() +
((ticket==null)?" from an unknown user": (" from "
+ + ticket.getUserName()));
}
private UserInformation getUserInfoPB(UserGroupInformation ugi) {
{code}
More review comments to follow.
> Thread safety of HTablePool is doubtful
> ---------------------------------------
>
> Key: HBASE-6651
> URL: https://issues.apache.org/jira/browse/HBASE-6651
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.94.1
> Reporter: Hiroshi Ikeda
> Priority: Minor
> Attachments: HBASE-6651.patch, sample.zip, sample.zip,
> sharedmap_for_hbaseclient.zip
>
>
> There are some operations in HTablePool to access to PoolMap in multiple
> times without any explict synchronization.
> For example HTablePool.closeTablePool() calles PoolMap.values(), and calles
> PoolMap.remove(). If other threads add new instances to the pool in the
> middle of the calls, the new added instances might be dropped.
> (HTablePool.closeTablePool() also has another problem that calling it by
> multple threads causes accessing HTable by multiple threads.)
> Moreover, PoolMap is not thread safe for the same reason.
> For example PoolMap.put() calles ConcurrentMap.get() and calles
> ConcurrentMap.put(). If other threads add a new instance to the concurent map
> in the middle of the calls, the new instance might be dropped.
> And also implementations of Pool have the same problems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
