[ 
https://issues.apache.org/jira/browse/HBASE-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474414#comment-13474414
 ] 

Hadoop QA commented on HBASE-6969:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12548702/6969v2.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
81 warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 5 new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestSplitLogManager

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3033//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3033//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3033//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3033//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3033//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3033//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3033//console

This message is automatically generated.
                
> Allow for injecting MiniZookeeperCluster instance
> -------------------------------------------------
>
>                 Key: HBASE-6969
>                 URL: https://issues.apache.org/jira/browse/HBASE-6969
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.92.1
>            Reporter: Micah Whitacre
>         Attachments: 6969v2.txt, hbase-6969.patch
>
>
> While not an official part of the HBase API, it'd be nice if 
> HBaseTestingUtility allowed for consumer to inject their own instance of the 
> MiniZookeeperCluster when executing tests.
> Currently there is no way to control how the ZK instance is started which 
> we've had to hack around when there were ZK version conflicts (3.3 vs 3.4).  
> Or if you want to control which specific port it starts on vs random.
> Allowing consumers to inject an instance (unstarted) gives them the freedom 
> to implement their own without having to fork the entire HBaseTestingUtility 
> class  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to