[
https://issues.apache.org/jira/browse/HBASE-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477397#comment-13477397
]
Lars Hofhansl commented on HBASE-6974:
--------------------------------------
Looks good. Few minor comments:
* I think you snug a divider by 1024 in there to convert from ms to s :)
* We should also collect another metric when this situation happens in the
memstore flusher (here it happens because of global memory pressure)
* Let's use EnvironmentEdge.currentTimeMillis()
* Nit: a call to currentTimeMillis is not free, we should only call it in the
!blocked part inside the while loop (which means it cannot be final, has to be
initialized with 0, etc)
> Metric for blocked updates
> --------------------------
>
> Key: HBASE-6974
> URL: https://issues.apache.org/jira/browse/HBASE-6974
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Michael Drzal
> Priority: Critical
> Fix For: 0.94.3, 0.96.0
>
> Attachments: HBASE-6974.patch
>
>
> When the disc subsystem cannot keep up with a sustained high write load, a
> region will eventually block updates to throttle clients.
> (HRegion.checkResources).
> It would be nice to have a metric for this, so that these occurrences can be
> tracked.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
