[
https://issues.apache.org/jira/browse/HBASE-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479469#comment-13479469
]
stack commented on HBASE-6945:
------------------------------
Does this patch make a class with no content? I'm looking at this section:
{code}
abstract static class OSResourceAnalyzer extends
ResourceChecker.ResourceAnalyzer {
- protected static final OperatingSystemMXBean osStats;
- protected static final UnixOperatingSystemMXBean unixOsStats;
-
- static {
- osStats = ManagementFactory.getOperatingSystemMXBean();
- if (osStats instanceof UnixOperatingSystemMXBean) {
- unixOsStats = (UnixOperatingSystemMXBean) osStats;
- } else {
- unixOsStats = null;
- }
- }
}
{code}
We seem to be removing the body of the class.
Should this class, OSMXBean, be renamed OS since it answers questions about the
OS in a way that insulates us against differences in JVM. Maybe a better name
would be JVM. Then you'd ask it for an implementation of
UnixOperatingSystemMXBean. It would take care of returning the IBM or Oracle
implementation. They both implement the UnixOperatingSystemMXBean Interface?
> Compilation errors when using non-Sun JDKs to build HBase-0.94
> --------------------------------------------------------------
>
> Key: HBASE-6945
> URL: https://issues.apache.org/jira/browse/HBASE-6945
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.94.1
> Environment: RHEL 6.3, IBM Java 7
> Reporter: Kumar Ravi
> Assignee: Kumar Ravi
> Labels: patch
> Fix For: 0.94.3
>
> Attachments: ResourceCheckerJUnitListener_HBASE_6945-trunk.patch
>
>
> When using IBM Java 7 to build HBase-0.94.1, the following comilation error
> is seen.
> [INFO] -------------------------------------------------------------
> [ERROR] COMPILATION ERROR :
> [INFO] -------------------------------------------------------------
> [ERROR]
> /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25]
> error: package com.sun.management does not exist
> [ERROR]
> /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25]
> error: cannot find symbol
> [ERROR] symbol: class UnixOperatingSystemMXBean
> location: class ResourceAnalyzer
> /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29]
> error: cannot find symbol
> [ERROR] symbol: class UnixOperatingSystemMXBean
> location: class ResourceAnalyzer
> /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23]
> error: cannot find symbol
> [INFO] 4 errors
> [INFO] -------------------------------------------------------------
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> I have a patch available which should work for all JDKs including Sun.
> I am in the process of testing this patch. Preliminary tests indicate the
> build is working fine with this patch. I will post this patch when I am done
> testing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
