[
https://issues.apache.org/jira/browse/HBASE-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480100#comment-13480100
]
Kumar Ravi commented on HBASE-6965:
-----------------------------------
>What JVMs and OS's did you test on out of interest? How many different vendor
>and OS strings did you test your patch against?
This was tested on Sun (Oracle) JDK 6 (1.6.0_34), OpenJDK 6 and IBM Java 7. All
tested on RHEL 6.3.
>It seems a big hacky looking for 'IBM' in vendor string figuring if an IBM JVM
>or not. Are you sure it's always upper case. Any other property >you could
>check to be sure it is the JVM you think. Does IBM only make a linux JDK?
We borrowed this idea from the code here in hadoop:
http://svn.apache.org/repos/asf/hadoop/common/tags/release-1.0.3/src/core/org/apache/hadoop/security/UserGroupInformation.java.
See methods getOSLoginModuleName() - Line 262 and getOsPrincipalClass() - Line
276.
> Generic MXBean Utility class to support all JDK vendors
> -------------------------------------------------------
>
> Key: HBASE-6965
> URL: https://issues.apache.org/jira/browse/HBASE-6965
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.94.1
> Reporter: Kumar Ravi
> Assignee: Kumar Ravi
> Labels: patch
> Fix For: 0.94.3, 0.96.0
>
> Attachments: HBASE-6965.patch, OSMXBean_HBASE-6965-0.94.patch
>
>
> This issue is related to JIRA
> https://issues.apache.org/jira/browse/HBASE-6945. This issue is opened to
> propose the use of a newly created generic
> org.apache.hadoop.hbase.util.OSMXBean class that can be used by other
> classes. JIRA HBASE-6945 contains a patch for the class
> org.apache.hadoop.hbase.ResourceChecker that uses OSMXBean. With the
> inclusion of this new class, HBase can be built and become functional with
> JDKs and JREs other than what is provided by Oracle.
> This class uses reflection to determine the JVM vendor (Sun, IBM) and the
> platform (Linux or Windows), and contains other methods that return the OS
> properties - 1. Number of Open File descriptors; 2. Maximum number of File
> Descriptors.
> This class compiles without any problems with IBM JDK 7, OpenJDK 6 as well
> as Oracle JDK 6. Junit tests (runDevTests category) completed without any
> failures or errors when tested on all the three JDKs.The builds and tests
> were attempted on branch hbase-0.94 Revision 1396305.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
