[ 
https://issues.apache.org/jira/browse/HBASE-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480508#comment-13480508
 ] 

Enis Soztutar commented on HBASE-6966:
--------------------------------------

Patch looks good. Two questions: 
1. What happens when the server does not support a compression set from the 
client. I guess we might want to throw DoNotRetryIOException, or a specific 
exception to let the client know that  it should not try to use the same 
compression.
2. we are introducing dependency to hfile.io in rpc layer. Ideally, we should 
refactor hfile.io to o.a.h.h.io. We can do it later in another issue I guess. 
                
> "Compressed RPCs for HBase" (HBASE-5355) port to trunk
> ------------------------------------------------------
>
>                 Key: HBASE-6966
>                 URL: https://issues.apache.org/jira/browse/HBASE-6966
>             Project: HBase
>          Issue Type: Improvement
>          Components: IPC/RPC
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.96.0
>
>         Attachments: 6966-1.patch, 6966-v2.txt
>
>
> This jira will address the port of the compressed RPC implementation to 
> trunk. I am expecting the patch to be significantly different due to the PB 
> stuff in trunk, and hence filed a separate jira.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to