[
https://issues.apache.org/jira/browse/HBASE-6597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481530#comment-13481530
]
Phabricator commented on HBASE-6597:
------------------------------------
Kannan has commented on the revision "[jira] [HBASE-6597] [89-fb] Incremental
data block encoding".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/encoding/CopyKeyDataBlockEncoder.java:29
Regarding the second bullet (in my comment), I suppose it is ok to leave this
as is... as it does simplify the calling logic a little bit. We should just add
here in comments that
* this is used for non-encoded blocks.
* and, keeps blocks in old format (without the DBE specific headers).
src/main/java/org/apache/hadoop/hbase/io/encoding/FastDiffDeltaEncoder.java:35
use integer compression for key, value and prefix (7-bit encoding)
-->
use integer compression for key, value and prefix lengths (7-bit encoding)
src/main/java/org/apache/hadoop/hbase/io/encoding/DiffKeyDeltaEncoder.java:34
ditto (as other comment)
s/prefix/prefix lengths
REVISION DETAIL
https://reviews.facebook.net/D5895
To: Kannan, Karthik, Liyin, aaiyer, avf, JIRA, mbautin
Cc: tedyu
> Block Encoding Size Estimation
> ------------------------------
>
> Key: HBASE-6597
> URL: https://issues.apache.org/jira/browse/HBASE-6597
> Project: HBase
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.89-fb
> Reporter: Brian Nixon
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D5895.1.patch, D5895.2.patch, D5895.3.patch,
> D5895.4.patch
>
>
> Blocks boundaries as created by current writers are determined by the size of
> the unencoded data. However, blocks in memory are kept encoded. By using an
> estimate for the encoded size of the block, we can get greater consistency in
> size.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
