[
https://issues.apache.org/jira/browse/HBASE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486254#comment-13486254
]
Ted Yu commented on HBASE-3909:
-------------------------------
For ClusterConfigTracker:
{code}
+ // Cluster configuration already exists in ZK.
+ LOG.info("ZK Cluster Config already available. Skipping config ZK node
creation");
{code}
The above log should be debug. The second sentence actually belongs to
initClusterConfig()
For updateClusterConfig(String configKey, String configValue):
{code}
+ } catch (KeeperException e) {
+ LOG.error("Failure during update cluster configuration", e);
{code}
Please include configKey in the above log.
The change in ServerManager.java is unrelated, please remove from next patch.
For update_config.rb and get_config.rb, the following is not needed:
{code}
+# Copyright 2011 The Apache Software Foundation
{code}
For HBaseAdmin.java, the following line exceeds 100 characters long:
{code}
+ UpdateConfigRequest request =
RequestConverter.buildUpdateConfigRequest(configKey, configValue);
{code}
Currently only one pair of key / value is updated per UpdateConfigRequest:
{code}
+message UpdateConfigRequest {
+ required string configKey = 1;
+ required string configValue = 2;
+}
{code}
Shall we accommodate more than one pair (through repeated keyword) ?
> Add dynamic config
> ------------------
>
> Key: HBASE-3909
> URL: https://issues.apache.org/jira/browse/HBASE-3909
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Subbu M Iyer
> Fix For: 0.96.0
>
> Attachments: 3909_090712-2.patch, 3909-102812.patch,
> 3909-102912.patch, 3909.v1, 3909-v1.patch, HBase Cluster Config Details.xlsx,
> patch-v2.patch
>
>
> I'm sure this issue exists already, at least as part of the discussion around
> making online schema edits possible, but no hard this having its own issue.
> Ted started a conversation on this topic up on dev and Todd suggested we
> lookd at how Hadoop did it over in HADOOP-7001
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
