Jean-Daniel Cryans created HBASE-7073:
-----------------------------------------
Summary: OperationMetrics needs to cache the value of
hbase.metrics.exposeOperationTimes
Key: HBASE-7073
URL: https://issues.apache.org/jira/browse/HBASE-7073
Project: HBase
Issue Type: Improvement
Affects Versions: 0.94.2
Reporter: Jean-Daniel Cryans
Assignee: Elliott Clark
Priority: Minor
Fix For: 0.94.4
Trying some increments on my local machine I was surprised to see this in my
jstacks:
{noformat}
java.lang.Thread.State: RUNNABLE
at
org.apache.hadoop.conf.Configuration.getProps(Configuration.java:1061)
- locked <7c4a26430> (a org.apache.hadoop.conf.Configuration)
at org.apache.hadoop.conf.Configuration.get(Configuration.java:416)
at
org.apache.hadoop.hbase.regionserver.CompoundConfiguration$1.get(CompoundConfiguration.java:94)
at
org.apache.hadoop.hbase.regionserver.CompoundConfiguration.get(CompoundConfiguration.java:186)
at
org.apache.hadoop.hbase.regionserver.CompoundConfiguration.getBoolean(CompoundConfiguration.java:318)
at
org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doSafeIncTimeVarying(OperationMetrics.java:217)
at
org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doUpdateTimeVarying(OperationMetrics.java:212)
at
org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.updateIncrementMetrics(OperationMetrics.java:133)
at
org.apache.hadoop.hbase.regionserver.HRegion.increment(HRegion.java:4817)
{noformat}
It's a pretty horrible lookup that's inline with everything else in that class
and there's no reason why it shouldn't be a final boolean.
Assigning this to the master of metrics since he asked for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
