[
https://issues.apache.org/jira/browse/HBASE-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487393#comment-13487393
]
Ted Yu commented on HBASE-4583:
-------------------------------
Putting the patch on review board, I was able to understand the changes better
:-)
completeMemstoreInsert() doesn't throw exception:
{code}
public void completeMemstoreInsert(WriteEntry e) {
{code}
I wonder if the last mvcc.completeMemstoreInsert(w) call can be latched onto
(before) closeRegionOperation():
{code}
+ mvcc.completeMemstoreInsert(w);
}
- if (writeToWAL) {
- syncOrDefer(txid); // sync the transaction log outside the rowlock
- }
} finally {
closeRegionOperation();
{code}
This way there is no need to add one more try / catch block.
There are also some white spaces introduced in patch v5.
> Integrate RWCC with Append and Increment operations
> ---------------------------------------------------
>
> Key: HBASE-4583
> URL: https://issues.apache.org/jira/browse/HBASE-4583
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.96.0
>
> Attachments: 4583-trunk-less-radical.txt,
> 4583-trunk-less-radical-v2.txt, 4583-trunk-less-radical-v3.txt,
> 4583-trunk-less-radical-v4.txt, 4583-trunk-less-radical-v5.txt,
> 4583-trunk-radical.txt, 4583-trunk-radical_v2.txt, 4583-trunk-v3.txt,
> 4583.txt, 4583-v2.txt, 4583-v3.txt, 4583-v4.txt
>
>
> Currently Increment and Append operations do not work with RWCC and hence a
> client could see the results of multiple such operation mixed in the same
> Get/Scan.
> The semantics might be a bit more interesting here as upsert adds and removes
> to and from the memstore.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
