[
https://issues.apache.org/jira/browse/HBASE-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487478#comment-13487478
]
stack commented on HBASE-6410:
------------------------------
Here are some comments on pages 8 through 11 or so:
MetricsRegion needs class doc. What is it? Utility? Glue between Region
Source and HRegion? Is it needed?
37
private MetricsRegionServerSource generalSource;
data member name should be serverSource?
Ditto on MetricsRegionServer. Is it glue between RegionServer and metrics?
35
Is it only for JMX? (See below)
* Impl for exposing HRegionServer Information through JMX
36
*/
37
@InterfaceAudience.Private class MetricsRegionServerWrapperImpl
Then above line is formatted strange.
Fix this '246
* This is the runnable that will be executed on the executor ever PERIOD
number of seconds'
Just remove TestExponentiallyDecayingSample.java? And the other deprecated
tests?
> Move RegionServer Metrics to metrics2
> -------------------------------------
>
> Key: HBASE-6410
> URL: https://issues.apache.org/jira/browse/HBASE-6410
> Project: HBase
> Issue Type: Sub-task
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Blocker
> Attachments: HBASE-6410-13.patch, HBASE-6410-1.patch,
> HBASE-6410-2.patch, HBASE-6410-3.patch, HBASE-6410-4.patch,
> HBASE-6410-5.patch, HBASE-6410-6.patch, HBASE-6410.patch
>
>
> Move RegionServer Metrics to metrics2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
