[
https://issues.apache.org/jira/browse/HBASE-7031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488277#comment-13488277
]
Phabricator commented on HBASE-7031:
------------------------------------
tjackson has commented on the revision "[jira] [HBASE-7031] [89-fb] Add
startRow/endRow to TableInputFormat".
A few little things, but otherwise this looks good. Could you grab someone
more familiar with HBase/MR to accept?
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/mapred/TableInputFormatBase.java:132
ultranit: space after comma.
src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java:73
I'd make the field the concrete type, since it's private. This will let Java
see what methods are final and avoid the virtual invocations costs.
src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java:227
Can't you just declare the method ##synchronized##?
REVISION DETAIL
https://reviews.facebook.net/D6129
To: Kannan, Karthik, JIRA, mbautin, pritamdamania
Cc: tjackson
> Support startRow/endRow in TableInputFormat
> -------------------------------------------
>
> Key: HBASE-7031
> URL: https://issues.apache.org/jira/browse/HBASE-7031
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Priority: Minor
> Attachments: D6129.3.patch
>
>
> We are still using org.apache.hadoop.hbase.mapred.TableInputFormat (as
> opposed to org.apache.hadoop.hbase.mapreduce.TableInputFormat) for Hadoop
> Streaming integration. We need to add startRow/endRow support to
> TableInputFormat due to a product requirement. However, the two
> TableInputFormat implementations have diverged over time. We need to make
> mapred.TableInputFormat reuse some of the newer code in
> mapreduce.TableInputFormat, and add startRow/endRow support to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
