[
https://issues.apache.org/jira/browse/HBASE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-6651:
--------------------------
Description:
There are some operations in HTablePool accessing PoolMap in multiple places
without any explicit synchronization.
For example HTablePool.closeTablePool() calls PoolMap.values(), and calls
PoolMap.remove(). If other threads add new instances to the pool in the middle
of the calls, the newly added instances might be dropped.
(HTablePool.closeTablePool() also has another problem that calling it by
multiple threads causes accessing HTable by multiple threads.)
Moreover, PoolMap is not thread safe for the same reason.
For example PoolMap.put() calles ConcurrentMap.get() and calles
ConcurrentMap.put(). If other threads add a new instance to the concurent map
in the middle of the calls, the new instance might be dropped.
And also implementations of Pool have the same problems.
was:
There are some operations in HTablePool to access to PoolMap in multiple times
without any explict synchronization.
For example HTablePool.closeTablePool() calles PoolMap.values(), and calles
PoolMap.remove(). If other threads add new instances to the pool in the middle
of the calls, the new added instances might be dropped.
(HTablePool.closeTablePool() also has another problem that calling it by
multple threads causes accessing HTable by multiple threads.)
Moreover, PoolMap is not thread safe for the same reason.
For example PoolMap.put() calles ConcurrentMap.get() and calles
ConcurrentMap.put(). If other threads add a new instance to the concurent map
in the middle of the calls, the new instance might be dropped.
And also implementations of Pool have the same problems.
> Improve thread safety of HTablePool
> -----------------------------------
>
> Key: HBASE-6651
> URL: https://issues.apache.org/jira/browse/HBASE-6651
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.94.1
> Reporter: Hiroshi Ikeda
> Assignee: Hiroshi Ikeda
> Fix For: 0.96.0
>
> Attachments: HBASE-6651.patch, HBASE-6651-V2.patch,
> HBASE-6651-V3.patch, HBASE-6651-V4.patch, HBASE-6651-V5.patch,
> HBASE-6651-V6.patch, sample.zip, sample.zip, sharedmap_for_hbaseclient.zip
>
>
> There are some operations in HTablePool accessing PoolMap in multiple places
> without any explicit synchronization.
> For example HTablePool.closeTablePool() calls PoolMap.values(), and calls
> PoolMap.remove(). If other threads add new instances to the pool in the
> middle of the calls, the newly added instances might be dropped.
> (HTablePool.closeTablePool() also has another problem that calling it by
> multiple threads causes accessing HTable by multiple threads.)
> Moreover, PoolMap is not thread safe for the same reason.
> For example PoolMap.put() calles ConcurrentMap.get() and calles
> ConcurrentMap.put(). If other threads add a new instance to the concurent map
> in the middle of the calls, the new instance might be dropped.
> And also implementations of Pool have the same problems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
