[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils

[Gustavo Anatoly (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491463#comment-13491463
 ] 

Gustavo Anatoly commented on HBASE-6356:
----------------------------------------

Hi, nkeywal.

Could you verify if you are agree with this message to LOG.warn?  

{noformat}
public boolean accept(Path p) {
  boolean isValid = false;
  try {
    if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
      isValid = false;
    } else {
      isValid = this.fs.getFileStatus(p).isDir();
    }
  } catch (IOException e) {
    LOG.warn("An error occured while verify [" + p.toString() + "] if is a 
valid directory.", e);
  }
  return isValid;
}
{noformat}

If you are agree, I will submit a new patch.

Thanks.
                
> printStackTrace in FSUtils
> --------------------------
>
>                 Key: HBASE-6356
>                 URL: https://issues.apache.org/jira/browse/HBASE-6356
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, master, regionserver
>    Affects Versions: 0.96.0
>            Reporter: nkeywal
>            Priority: Trivial
>              Labels: noob
>
> This is bad...
> {noformat}
>     public boolean accept(Path p) {
>       boolean isValid = false;
>       try {
>         if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
>           isValid = false;
>         } else {
>             isValid = this.fs.getFileStatus(p).isDir();
>         }
>       } catch (IOException e) {
>         e.printStackTrace();          <================ 
>       }
>       return isValid;
>     }
>   }
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira