[
https://issues.apache.org/jira/browse/HBASE-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491864#comment-13491864
]
Jonathan Hsieh commented on HBASE-6865:
---------------------------------------
(Oops, there was a point 3 but it got folded into one of the others).
[~te...@apache.org] Take a look at this link and some of the comments around
it and its analog.
https://reviews.apache.org/r/7627/diff/2/?file=183690#file183690line64
Setters conventionally don't io, doesn't start threads, and can be called
anytime in the lifecycle of an object. In the code in this patch, the conf
being is more like part of a constructor or a thread start method.
Specifically, it instantiates a cache object that has a thread. Hm.. I should
have asked why it wasn't in the constructor -- I'll add that to the review.
> Snapshot File Cleaners
> ----------------------
>
> Key: HBASE-6865
> URL: https://issues.apache.org/jira/browse/HBASE-6865
> Project: HBase
> Issue Type: Sub-task
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: hbase-6055
>
>
> HFile and HLog cleaners are necessary for fully implementing snapshots, but
> can be broken out into their own piece really cleanly. The HFile cleaner is
> necessary for both timestamp and globally consistent snapshots, but the HLog
> cleaner is necessary for globally consistent and offline snapshots.
> Putting everything together in one patch isn't too much overload as there is
> a lot of overlap between the cleaners.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
