[ 
https://issues.apache.org/jira/browse/HBASE-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493401#comment-13493401
 ] 

Liyin Tang commented on HBASE-7106:
-----------------------------------

Gustavo Anatoly: I didn't fully understand your questions :) The pom change is 
orthogonal with the code change.

Jimmy, The semantics of NULL column qualifier is equal to that of the 
EMPYT_BYTE_ARRAY column qualifier. 
However, the fix in HBASE-6206 will skip the NULL qualifier.
-    set.add(qualifier);
+    if (qualifier != null) {
+      set.add(qualifier);
+    }

=========
I think the correct fix shall be:

if (qualifier != null) {
  set.add(qualifier);
} else {
  set.add(HConstants.EMPTY_BYTE_ARRAY);
}
                
> [89-fb] Fix the NPE in unit tests for JDK7
> ------------------------------------------
>
>                 Key: HBASE-7106
>                 URL: https://issues.apache.org/jira/browse/HBASE-7106
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liyin Tang
>            Priority: Trivial
>
> In JDK7, it will throw out NPE if put a NULL into a TreeSet. And in the unit 
> tests, user can add a NULL as qualifier into the family map for GET or SCAN. 
> So we shall do the followings: 
> 1) Make sure the semantics of NULL column qualifier is equal to that of the 
> EMPYT_BYTE_ARRAY column qualifier.
> 2) An easy fix is to use the EMPYT_BYTE_ARRAY qualifier to replace NULL 
> qualifier in the family map for the GET or SCAN objects, and everything else 
> shall be backward compatible.
> 3) Add a jdk option in the pom.xml (Assuming user installed the fb packaged 
> jdk)
> eg: mvn test -Dtest=TestFromClientSide -Pjdk7

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to