[ https://issues.apache.org/jira/browse/HBASE-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494438#comment-13494438 ]
Ted Yu commented on HBASE-6830: ------------------------------- Patch looks good. nit: no need to change style of comment {code} - // Directory where we put the data for this instance of HBaseTestingUtility. + /** Directory where we put the data for this instance of HBaseTestingUtility*/ {code} > [WINDOWS] Tests should not rely on local temp dir to be available in DFS > ------------------------------------------------------------------------ > > Key: HBASE-6830 > URL: https://issues.apache.org/jira/browse/HBASE-6830 > Project: HBase > Issue Type: Bug > Components: test > Affects Versions: 0.94.3, 0.96.0 > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Labels: window > Attachments: hbase-6830_v1-0.94.patch, hbase-6830_v1-trunk.patch, > hbase-6830_v5-0.94.patch, hbase-6830_v5-trunk.patch > > > Some of the tests resolve the local temp directory for temporary test data, > but use this directory path in dfs. Since on windows, local temp dir is > resolved to something like: c:\\<path_to_local_dir>, > DistributedFileSystem.getPathName() throws an IllegalArgumentException > complaining that it is not a valid path name. > Instead of relying on a local temp dir name, we should create a temp dir on > dfs, and use this as a basis dir for test data. > At least the following test cases are affected by this: > {code} > TestHFileOutputFormat > TestHRegionServerBulkLoad > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira