[ 
https://issues.apache.org/jira/browse/HBASE-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497943#comment-13497943
 ] 

Daniel Gómez Ferro commented on HBASE-7155:
-------------------------------------------

Hi Stack,

Since the documentation claimed RootRegionTracker.getRootRegionLocation() would 
not block, I assumed it made no sense to throw an IE. But it seems the method 
can block waiting for ZK and an IE can be swallowed in 
ZKUtil.getDataInternal(). 

I see several options:
# Swallow the IE and apply the proposed changes (removing the IE from the upper 
layers)
# Expose the IE to RootRegionTracker.getRootRegionLocation() 
# Make RootRegionTracker.getRootRegionLocation() truly non blocking.
                
> Excessive usage of InterruptedException where it can't be thrown
> ----------------------------------------------------------------
>
>                 Key: HBASE-7155
>                 URL: https://issues.apache.org/jira/browse/HBASE-7155
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Daniel Gómez Ferro
>            Assignee: Daniel Gómez Ferro
>         Attachments: HBASE-7155.patch
>
>
> RootRegionTracker.getRootRegionLocation() declares that it can throw an 
> InterruptedException, but it can't. This exception is rethrown by many other 
> functions reaching the HBaseAdmin API.
> If we remove the throws statement from the HBaseAdmin API libraries already 
> compiled will work fine, but if the user is trying to catch an 
> InterruptedException around one of those methods the compiler will complain.
> Should we clean this up?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to