[
https://issues.apache.org/jira/browse/HBASE-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498531#comment-13498531
]
Hadoop QA commented on HBASE-7172:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12553720/hbase-7172_v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
93 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 16 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3349//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3349//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3349//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3349//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3349//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3349//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3349//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3349//console
This message is automatically generated.
> TestSplitLogManager.testVanishingTaskZNode() fails when run individually and
> is flaky
> -------------------------------------------------------------------------------------
>
> Key: HBASE-7172
> URL: https://issues.apache.org/jira/browse/HBASE-7172
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.96.0, 0.94.4
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: hbase-7172_v1.patch
>
>
> TestSplitLogManager.testVanishingTaskZNode fails when run individually (run
> just that test case from eclipse). I've also noticed that it is flaky on
> windows.
> The reason is a rare race condition, which somehow does not happen that much
> when the whole class is run.
> The sequence of events is smt like this:
> - we create 1 log file to split
> - we call splitLogDistributed() in its own thread.
> - splitLogDistributed() is waiting in waitForSplittingCompletion() since
> there are no splitlogworkers, it keep waiting.
> - we delete the task znode from zk
> - SplitLogManager receives the zk callback from GetDataAsyncCallback, which
> will call setDone() and mark the task as success.
> - However, meanwhile the waitForSplittingCompletion() loops sees that
> remainingInZK == 0, and calls return concurrently to the above.
> - on return from waitForSplittingCompletion(), splitLogDistributed() fails
> because the znode delete callback has not completed yet.
> This race only happens when the last task is deleted from zk, and normally
> only the SplitLogManager deletes the task znodes after processing it, so I
> don't think this is a production issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
