[ 
https://issues.apache.org/jira/browse/HBASE-7109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501628#comment-13501628
 ] 

Ted Yu commented on HBASE-7109:
-------------------------------

{code}
+  * A class is considered as a test class if:
+   *  - it's not Abstract AND
+   *  - one or more of its methods is annotated with org.junit.Test OR
+   *  - the class is annotated with Suite.SuiteClasses
+  * */
+  private static class TestClassFilter implements ClassFilter {
{code}
Do we need to consider tests that extend junit.framework.TestCase ?
A few examples: TestCompare, TestBase64.
There is also:
{code}
public abstract class HBaseTestCase extends TestCase {
{code}
We have:
{code}
public class TestHRegion extends HBaseTestCase {
{code}
{code}
+    public boolean isCandidateClass(Class<?> c) {
+      return isTestClass(c) && isCategorizedClass(c);
{code}
Some test classes don't satisfy both conditions above (methods aren't annotated 
with @Test in TestBase64).
                
> integration tests on cluster are not getting picked up from distribution
> ------------------------------------------------------------------------
>
>                 Key: HBASE-7109
>                 URL: https://issues.apache.org/jira/browse/HBASE-7109
>             Project: HBase
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: 0.96.0
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HBASE-7109-squashed.patch, HBASE-7109-v2-squashed.patch, 
> HBASE-7109-v3-squashed.patch, HBASE-7109-v4-squashed.patch, 
> HBASE-7109-v5.patch, HBASE-7109-v5.patch
>
>
> The method of finding test classes only works on local build (or its full 
> copy), not if the distribution is used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to