[ 
https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503192#comment-13503192
 ] 

Jonathan Hsieh commented on HBASE-7204:
---------------------------------------

{code}
+    String className = System.getProperty("hbasefsck.errorreporter");
{code}

Why is this System property?  Why not a configuration property? (command line 
overrideable via -Dhbasefsck.errorreporter)?

otherwise, lgtm.
                
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
>                 Key: HBASE-7204
>                 URL: https://issues.apache.org/jira/browse/HBASE-7204
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbck
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>         Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to